Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vat upgrade: 14 mintHolders #10410

Open
14 tasks
Chris-Hibbert opened this issue Nov 6, 2024 · 0 comments
Open
14 tasks

Vat upgrade: 14 mintHolders #10410

Chris-Hibbert opened this issue Nov 6, 2024 · 0 comments
Labels
contract-upgrade enhancement New feature or request ERTP package: ERTP

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

As mentioned in #8158, we need the ability to restart or replace all vats. This issue is concerned with upgrading the 14 existing mintHolder contracts.

Description of the Design

The source code is mintHolder.js. These are not Zoe contracts. upgrade-vats.test.ts shows that They are upgradeable, though it doesn't test functionality. We should upgrade a mintHolder in a3p-integration and show that it continues to function correctly.

  • v13: BLD
  • v16: ATOM
  • v17: USDC_axl
  • v18: USDC_grv
  • v19: USDT_axl
  • v20: USDT_grv
  • v21: DAI_axl
  • v22: DAI_grv
  • v66: stATOM
  • v71: USDC
  • v72: USDT
  • v96: stOSMO
  • v102: stTIA
  • v109: stkATOM

We should upgrade a few at first, and more over time.

Security Considerations

mintHolders are the foundation for a lot of assets on our chain.

Scaling Considerations

Not significant. Measurements haven't shown any indication of problems.

Test Plan

As above. test in a3p-integration.

Upgrade Considerations

As above. Don't upgrade them all at once.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request ERTP package: ERTP contract-upgrade labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contract-upgrade enhancement New feature or request ERTP package: ERTP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chris-Hibbert