Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones do not enforce redefinition of the same "kind" #10434

Open
mhofman opened this issue Nov 9, 2024 · 0 comments
Open

Zones do not enforce redefinition of the same "kind" #10434

mhofman opened this issue Nov 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working contract-upgrade

Comments

@mhofman
Copy link
Member

mhofman commented Nov 9, 2024

Describe the bug

My memory is a little fuzzy on this, but I remember when looking at zones and how we were storing kind handles that there was the possibility that the user could define one kind of exo in place for another one (e.g. a multi kind for a single facet kind), and things would fail with an obscure error.

Not storing the expected kind definition may become a problem as we start to overload definitions (async-flow support in, see #10433), or need to provide migration strategies to newer features (e.g. state accessor, or power amplification).

Expected behavior

The ability for a zone to figure out the previously defined kind, and either error or provide backwards compatibility when kind definition don't fully match.

Additional context

This may be particularly relevant if we switch to a "slot" abstraction for zones. see endojs/endo#2397

@mhofman mhofman added bug Something isn't working contract-upgrade labels Nov 9, 2024
@mhofman mhofman self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contract-upgrade
Projects
None yet
Development

No branches or pull requests

1 participant