Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainHub method should be sync #10602

Open
3 tasks
0xpatrickdev opened this issue Dec 2, 2024 · 0 comments
Open
3 tasks

ChainHub method should be sync #10602

0xpatrickdev opened this issue Dec 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

What is the Problem Being Solved?

ChainHub contains a mixture of synchronous and asynchronous calls. All calls should be synchronous, see https://codecider-app.vercel.app/d/6fb8c4f7-1465-4b19-8d85-2326e29d8ffc/view#?!-what-chainhub-methods-should-be-async

Description of the Design

  • getChain() should be synchronous and no longer fallback to an agoricNames lookup
  • getConnectionInfo() should be synchronous and no longer fallback to an agoricNames lookup
  • getChainsAndConnection() should be synchronous and no longer fallback to an agoricNames lookup

Note: this requires contract authors to seed their chainHub at contract start time. With #10571 and #10329, orchestration example contracts + FUSDC all already do this.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant