Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-bundle does not work with "current" endo master #7947

Closed
erights opened this issue Jun 17, 2023 · 2 comments · Fixed by #7958
Closed

build-bundle does not work with "current" endo master #7947

erights opened this issue Jun 17, 2023 · 2 comments · Fixed by #7958
Assignees
Labels
bug Something isn't working

Comments

@erights
Copy link
Member

erights commented Jun 17, 2023

Using #7937 to try out "current" agoric-sdk master against "current" endo master, I'm getting a bunch of CI failures in the same place:

At https://github.com/Agoric/agoric-sdk/actions/runs/5295500873/jobs/9585898031?pr=7937#step:3:2927

$ node scripts/build-bundle.js
Failed with (TypeError#1)
TypeError#1: consumer.destroy is not a function

  at async Promise.all (index 0)
  at async run (packages/swingset-xsnap-supervisor/scripts/build-bundle.js:21:18)

Not immediately urgent because agoric-sdk still only depends on an earlier endo without this problem.

@erights
Copy link
Member Author

erights commented Jun 20, 2023

@michaelfig Did I understand correctly that you understand why we get this failure, but not why we did not get it until recently? Does that mean you also understand what we need to repair so we no longer get this failure?

@michaelfig
Copy link
Member

@michaelfig Did I understand correctly that you understand why we get this failure,

Yes! There were two separate source-map package versions in the Agoric SDK.

but not why we did not get it until recently?

It's a bug in my implementation of #endo-branch: XXX which plopped Endo packages into the agoric-sdk CI build without resolving the interdependencies correctly. That's why we got it only recently.

Does that mean you also understand what we need to repair so we no longer get this failure?

Yes! I still need to figure out the details, but a picture is emerging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants