inform VaultFactory about new Auctioneer #8735
Assignees
Labels
Comments
Chris-Hibbert
added
enhancement
|
fyi, @warner. |
|
#8049 proposes to move the auctioneer's public facet from VaultFactory's terms to private args. PrivateArgs can be changed on upgrade. (Can they be changed if It looks like 8049 solves this problem, and makes it possible to upgrade vaultFactory to know about a new Auctioneer. This doesn't allow the Auctioneer to be changed dynamically (without an upgrade), but that's sufficient for our current plan. |
|
#8757 includes code to switch from using the auctioneer's PublicFacet to its Instance, and to read a new value from PrivateArgs. |
Merged
mergify bot
added a commit
that referenced
this issue
Aug 13, 2024
_incidental_ ## Description Refactors the auction amount math out of the auction book and adds unit tests. I noticed an inconsistency so this adds an assertion to prevent that and a fix. Also a bunch of refactorings and docs to try to make this area of the code more clear. Reviewers, review by commit is recommended. ### Security Considerations The auction book now calls out to another module to do the math. Module from its own package though. ### Scaling Considerations no change ### Documentation Considerations not user facing ### Testing Considerations regression test ### Upgrade Considerations This won't go out until VaultFactory gets a new auctioneer. See, - #8735 - #8981 @Chris-Hibbert is working on the CoreEval and its test to deploy this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
The Auction contract is not upgradeable; the plan has been to replace it rather than upgrading it.
The VaultFactory learns about the Auction in its
terms, and has no mechanism to be informed about a replacement.Description of the Design
Figure out how to use upgrade vatParameters, or privateArgs, or add an creatorFacet or governed API to the VaultFactory in order to inform it of a new Auction it should use.
Security Considerations
ensure no closely held authority is revealed.
Scaling Considerations
N/A
Test Plan
test in A3P.
Upgrade Considerations
make it possible to upgrade vaultFactory and Auction.
The text was updated successfully, but these errors were encountered: