Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that smartWallet offer notifications survive Zoe upgrade #8789

Closed
Chris-Hibbert opened this issue Jan 22, 2024 · 2 comments · Fixed by #9283
Closed

test that smartWallet offer notifications survive Zoe upgrade #8789

Chris-Hibbert opened this issue Jan 22, 2024 · 2 comments · Fixed by #9283
Assignees
Labels

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Jan 22, 2024

What is the Problem Being Solved?

#8773 is an upgrade to walletFactory that addresses #8286. During development we tested (manually and in agoric-3-proposals) that offers created before the upgrade would continue to be tracked even if Zoe was upgraded. Unfortunately, those tests no longer run once the code is upgraded on chain, so we have to add new tests in a3p-integration. In order to test it, we'll need a hook to create an outstanding offer before performing the upgrade.

Description of the Design

  • Create an offer (e.g. 'agops inter bid by-price --price 1 --give 1.0IST --from $GOV1ADDR --keyring-backend test --offer-id perpetual-open-bid-12')
  • upgrade walletFactory
  • upgrade Zoe
  • Verify that the offer exists and can be interacted with. ('agops inter bid cancel --id perpetual-open-bid-12 --from $GOV1ADDR')

Security Considerations

None

Scaling Considerations

None

Test Plan

As above

Upgrade Considerations

smart wallets should survive Zoe upgrade.

@Chris-Hibbert Chris-Hibbert self-assigned this Jan 22, 2024
@Chris-Hibbert
Copy link
Contributor Author

Also verify that numWantsSatisfied is updated in vstorage, to address #8292.

@Chris-Hibbert
Copy link
Contributor Author

Blocked on A3P#74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant