Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate need to x/swingset params migration in upgrade handler #9255

Open
JimLarson opened this issue Apr 18, 2024 · 0 comments
Open

Eliminate need to x/swingset params migration in upgrade handler #9255

JimLarson opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

Upgrade-13 introduced (#8623) a new block into the upgrade handler:

m := swingsetkeeper.NewMigrator(app.SwingSetKeeper)
		err = m.MigrateParams(ctx)
		if err != nil {
			return mvm, err
		}

and this was propagated in the upgrade-14 and -15 handlers.

We don't want permanent entries like this in the upgrade handler. The minimal upgrade handler should simply call the per-module migrations:

		// Always run module migrations
		mvm, err := app.mm.RunMigrations(ctx, app.configurator, fromVm)
		if err != nil {
			return mvm, err
		}

Description of the Design

Ideally do any parameter migration as a per-module migration as needed.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant