We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade-13 introduced (#8623) a new block into the upgrade handler:
m := swingsetkeeper.NewMigrator(app.SwingSetKeeper) err = m.MigrateParams(ctx) if err != nil { return mvm, err }
and this was propagated in the upgrade-14 and -15 handlers.
We don't want permanent entries like this in the upgrade handler. The minimal upgrade handler should simply call the per-module migrations:
// Always run module migrations mvm, err := app.mm.RunMigrations(ctx, app.configurator, fromVm) if err != nil { return mvm, err }
Ideally do any parameter migration as a per-module migration as needed.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
What is the Problem Being Solved?
Upgrade-13 introduced (#8623) a new block into the upgrade handler:
and this was propagated in the upgrade-14 and -15 handlers.
We don't want permanent entries like this in the upgrade handler. The minimal upgrade handler should simply call the per-module migrations:
Description of the Design
Ideally do any parameter migration as a per-module migration as needed.
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: