Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-flow: deeper wake testing #9383

Open
erights opened this issue May 19, 2024 · 0 comments
Open

async-flow: deeper wake testing #9383

erights opened this issue May 19, 2024 · 0 comments
Assignees
Labels
asyncFlow related to membrane-based replay and upgrade of async functions bug Something isn't working

Comments

@erights
Copy link
Member

erights commented May 19, 2024

At #9097 (comment) @mhofman writes:

Technically the flow woke up on its own (wakeAll in prepareAsyncFlowTools) for both the following reasons:

  • it was defined as an eager waker (default)
  • it was in a failed state from a bad replay in the previous test.

A different approach may be to split this testGoodReplay test in 2, have the first one redefine the flow using startEager = false so it gets removed from the eager wakers, and only resolve v3 in the next test to verify that resolving the vow actually wakes up the flow. We should also verify then that the flow wasn't awoken before the vow resolution (probably can set a variable right after resolution of v3, and check that the variable is set inside the guest flow)

Given "A different approach may be" and due to limited time and immediate demand, I'm filing this rather than addressing it in #9097 itself. Should still be addressed in a later PR.

@erights erights added bug Something isn't working asyncFlow related to membrane-based replay and upgrade of async functions labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asyncFlow related to membrane-based replay and upgrade of async functions bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants