Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move core eval scripts out of proposals #9473

Open
turadg opened this issue Jun 8, 2024 · 0 comments
Open

move core eval scripts out of proposals #9473

turadg opened this issue Jun 8, 2024 · 0 comments
Labels
devex developer experience technical-debt

Comments

@turadg
Copy link
Member

turadg commented Jun 8, 2024

What is the Problem Being Solved?

They are used in the creation of proposals but they aren't proposals themselves. #9468 clarifies the difference.

Description of the Design

Change the package/src/proposals pattern to something else.

  • src/core - this works for some packages but vats/src/core already means something else
  • src/evals - workable but makes it seem like these primary code and part of the semver of the package
  • tools/evals - relegates them to tools which is a little less strict
  • evals - do they ever need to get out to NPM? maybe we can retain the package home for organization but do the actual building just by filesystem paths

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex developer experience technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant