Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests missing from master #9553

Closed
mhofman opened this issue Jun 21, 2024 · 0 comments · Fixed by #9557
Closed

integration tests missing from master #9553

mhofman opened this issue Jun 21, 2024 · 0 comments · Fixed by #9557
Assignees
Labels
bug Something isn't working

Comments

@mhofman
Copy link
Member

mhofman commented Jun 21, 2024

Describe the bug

#9481 (comment) removed some integration tests of features getting upgraded or deployed in the next upgrade (u16). Because of them missing, some changes were made to localchain that causes an error when re-introducing the tests

localchain › localchain passes tests

  localchain.test.js:32

   31:                                                  
   32:   t.is(await readPublished(nodePath), nodeValue);
   33: });                                              

  Difference (- actual, + expected):

  - '{"success":false,"error":"Error: In \\"query\\" method of (LocalChainKit public): result: cannot check unrecognized tag \\"Vow\\": (an object)"}'
  + '{"success":true}'

  › file://localchain.test.js:32:5

To Reproduce

Add tests back

Expected behavior

No error

Platform Environment

CI

Additional context

Screenshots

@mhofman mhofman added the bug Something isn't working label Jun 21, 2024
@mhofman mhofman linked a pull request Jun 21, 2024 that will close this issue
@mergify mergify bot closed this as completed in #9557 Jun 22, 2024
@mergify mergify bot closed this as completed in c65915e Jun 22, 2024
mhofman pushed a commit that referenced this issue Jun 22, 2024
closes: #9553

## Description
Restores tests deleted in #9481 and fixes a bug in localchain introduced since

### Security Considerations
None

### Scaling Considerations
None

### Documentation Considerations
None

### Testing Considerations
Restoring integration tests

### Upgrade Considerations
Needed for upgrade 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants