fully remove 'sim-chain' #9725
Labels
Comments
mergify bot
added a commit
that referenced
this issue
Jul 26, 2024
refs: #9725 ## Description On the path to, - #9725 Remove concessions in SwingSet to `@agoric/cosmic-swingset/src/sim-chain.js` by requiring a bridgeDevice. Since `sim-chain` is no longer supported, we remove the ability to use it from `@agoric/solo`. This makes several of the tests in `@agoric/solo` fail, so we skip those that relied on `sim-chain`, while continuing to test the `ag-solo` basic functionality. We don't remove `@agoric/solo` because it serves as an example of a non-chain SwingSet application, and @michaelfig would like to refactor it into a configuration of a general `agvm` program. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI suffices ### Upgrade Considerations On-chain uses always provide a bridge device. This does affect line numbers. It will go out with the next kernel upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
sim-chain is a function that we used to have to run the chain without
agdbut now we useagdand Docker liberally. (See #9480 (comment) )We've removed it from user docs but it has remnants in code. These create complexity and increase costs of code maintenance. There are too many things not implemented, and not simulated. There's also been some confusion about what parts are supposed to still work.
Description of the Design
Remove all references to
sim-chain.@mhofman writes,
Related:
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: