Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multichain e2e: build agoric-sdk from source in ci #9805

Open
0xpatrickdev opened this issue Jul 30, 2024 · 1 comment
Open

multichain e2e: build agoric-sdk from source in ci #9805

0xpatrickdev opened this issue Jul 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Jul 30, 2024

What is the Problem Being Solved?

Currently, starship is configured to run with agoric-sdk:dev (the latest published image) in CI:
https://github.com/Agoric/agoric-sdk/blob/master/multichain-testing/config.yaml#L4

This approach works when we need to test example contract changes, but potentially falls short if there are changes in agoric-sdk we need to test.

Description of the Design

  1. Use the build directive to reference a commit hash and build the chain image from scratch:
    https://docs.cosmology.zone/starship/config/chains#build-optional

  2. Make this change in a new config.ci.yaml file that's only run during CI. Preserve the existing config.yaml so other consumer do not need to build the chain every time they wish to run starship.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@0xpatrickdev
Copy link
Member Author

This will likely be superseded by #10119 - we can depend on the docker image built in the PR instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant