postal service limited to issuers from startInstance

[dckc]

the postal service contract doesn't dynamically add issuers like the swaparoo contract does.

noted by @samsiegart in #45

Design

let clients give issuers to add in the invitationArgs

[dckc]

I'm not sure about the security implications of letting clients unilaterally add issuers. Added needs-design.

[samsiegart]

Thanks for making an issue.

I'm not sure about the security implications of letting clients unilaterally add issuers. Added needs-design.

If the design was up to me right now, I'd just allow it. We already do the same with swaparoo. If we ever decide to deploy this to mainnet, perhaps we could revisit these concerns?

[dckc]

I suppose as long as the clients don't get to choose names / keywords, it should be fine.

dapp-agoric-basics/contract/src/swaparoo.contract.js

Line 199 in 8d801d9

zcf.saveIssuer(i, `Issuer${(issuerNumber += 1)}`);

So the design would be, like swaparoo, to let clients give issuers to add in the invitationArgs? (or offerArgs)

[samsiegart]

So the design would be, like swaparoo, to let clients give issuers to add in the invitationArgs? (or offerArgs)

Yea, in invitationArgs