errors about RUN value descripencies & non-valid payments when opening up a vault

[tgrecojs]

Describe the bug

Can't successfully open up a vault within the dapp-treasury UI. Below is a video showing a group of failed vaults and the error message they provide. Whereas the UI error messages state that the following:

Requested {"brand":"[Alleged: RUN brand]","value":"[10001000n]"} exceeds max {"brand":"[Alleged: RUN brand]","value":"[9999993n]"}

The "value" properties above don't match up, and this is currently the behavior i'm always experiencing. I'm not sure if it has to do with the RUN fees but the difference between each "value" is extremely small which leads me to think that this might have something to do with it. For example, the difference in the BigInt values above is1.007n.

Inspecting the stack trace led me to finding a different error, further down than the error above, in which my local chain fails to validate the payment for opening a vault.

"[Alleged: BLD payment]" was not a live payment for brand "[Alleged: BLD brand]" . It could be a used-up payment, a payment for another brand, or it might not be a payment at all.

To Reproduce

Steps to reproduce the behavior:

1. follow instructions in dapp-treasury README.md to being running the dapp along with a local solo chain which uses the ui/use-on-chain-config.js properties.
2. navigate to the dapp-treasury UI and open a vault using any collateral type.
3. Navigate to wallet UI and accept payment.
4. View failed Vault creation within UI as well as console running the local chain.

Expected behavior

The treasury dapp should recognize that the payments are valid live payments and that the values embedded within these payments are correct.

Platform Environment

tg@Thomass-Mac-mini-2 ui % node -v
v14.18.1
tg@Thomass-Mac-mini-2 ui % npm -v
6.14.15

• is there anything special/unusual about your platform? No.
• what version of the Agoric-SDK are you using? (run git describe --tags --always): @agoric/[email protected]

Screenshots

dapp-treasury.payment.issue.mp4

[tgrecojs]

Following up on this after successfully opening a vault via docker instance. I happened to have docker-compose printing out logs when using the dapp.

When running via docker, it doesn't print the other error involving the values that I get while running agoric start --reset -v cmd but it does print the following:

SwingSet: vat: v10: Error depositing payment in default purse [Error: (an object) was not a live payment for brand (an object). It could be a used-up payment, a payment for another brand, or it might not be a payment at all.]

[samsiegart]

Thanks for reporting this, this seems to be related to #48. Could you confirm if this is fixed now for you?

[tgrecojs]

np @samsiegart

I can confirm that it's working as expected now 👍

thanks for linking to that issue as well

edit

happened to inspect the logs and noticed that the following error is still printing out in my console.

Error#3: "[Alleged: BLD payment]" was not a live payment for brand "[Alleged: BLD brand]" . It could be a used-up payment, a payment for another brand, or it might not be a payment at all.
Error: (an object) was not a live payment for brand (an object). It could be a used-up payment, a payment for another brand, or it might not be a payment at all.

again, the ability to open up a vault is no longer broken, but felt it worth adding in here

[Tartuffo]

@samsiegart to investigate if this is a dup.

[samsiegart]

Looks like this lingering error is not the same as Agoric/agoric-sdk#3982, needs more investigation

[Tartuffo]

@samsiegart is this still an issue or a dup?

[samsiegart]

It's not a dup, but also not RC0