Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

run typecheck in CI #120

Closed
wants to merge 5 commits into from
Closed

run typecheck in CI #120

wants to merge 5 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 2, 2022 •
edited
Loading

closes: #97, deferring the ability to do integration tests because this isn't reading the types yet from SDK

changes are detailed in clean commits

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

🚀 Deployed on https://62994265c3c78c031ab25b1c--agoric-dapp-treasury.netlify.app

@turadg turadg requested review from samsiegart and dckc June 2, 2022 23:13
@turadg turadg marked this pull request as ready for review June 2, 2022 23:13
@turadg turadg marked this pull request as draft June 2, 2022 23:40
@turadg
Copy link
Member Author

turadg commented Jun 2, 2022

Put back to draft because I recalled that changing jsconfig to tsconfig breaks import of types from JS files. for example this becomes any:

dapp-treasury/ui/src/types/types.js

Lines 162 to 165 in 2f02253

/**
* @typedef { import('@agoric/run-protocol/src/vaultFactory/vaultManager').AssetState } AssetState
*/
)

@turadg turadg mentioned this pull request Jun 3, 2022
Open
@turadg
Copy link
Member Author

turadg commented Dec 1, 2022

Closing in favor of investing in dapp-inter

@turadg turadg closed this Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samsiegart samsiegart Awaiting requested review from samsiegart

@dckc dckc Awaiting requested review from dckc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement type checking
1 participant
@turadg