Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing a core eval proposal #1190

Open
0xpatrickdev opened this issue Sep 6, 2024 · 2 comments
Open

testing a core eval proposal #1190

0xpatrickdev opened this issue Sep 6, 2024 · 2 comments

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Sep 6, 2024

What is the Problem Being Solved?

In dapp-offer-up, we have tests for bundling a contract and building a proposal (test-bundle-source.js) and (test-build-proposal.js). It doesn't seem we have a test that executes the proposal. Instead, the proposal is tested via a CoreEval and governance on a3p. This leads to a slow development iteration cycle.

Similarly, I can't find anything on docs.agoric.com that indicates how this could be tested.

Description of the Design

dapp-offer-up

In agoric-sdk, one way to test this sort of thing is with boot tests - a combination of swingset-vat/tools/run-utils.js and a walletFactory driver. This allows the developer to test their proposal and send offers from an offchain wallet client. The OfferSpec artifacts from these sort of tests are really helpful when it comes time to build a UI.

I think this sort of testing should be made available in all dapp templates.

documentation

@0xpatrickdev
Copy link
Member Author

Oops - seems I misread - test-contract.js in dapp-offer-up does appear to test a proposal.

@dckc
Copy link
Member

dckc commented Sep 7, 2024

including boot test support in dapp templates is still a good idea; maybe this should be re-scoped to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants