Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types from packages/ui-components #84

Closed
samsiegart opened this issue Feb 22, 2024 · 1 comment
Closed

Export types from packages/ui-components #84

samsiegart opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@samsiegart
Copy link
Contributor

What is the Problem Being Solved?

ui-components doesn't export types, so building typescript dapps requires declaring the types on your own. Example issue:
Agoric/dapp-offer-up#64 (comment)

Example workaround with vite: https://github.com/Agoric/dapp-offer-up/blob/main/ui/src/vite-env.d.ts

Description of the Design

Export the types in the package so typescript packages can import ui-components without declaring types on their own

@samsiegart
Copy link
Contributor Author

Fixed in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant