Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapse/resize params drawer #64

Open
sneakers-the-rat opened this issue Nov 29, 2023 · 1 comment
Open

collapse/resize params drawer #64

sneakers-the-rat opened this issue Nov 29, 2023 · 1 comment

Comments

@sneakers-the-rat
Copy link
Contributor

Got a verbal issue from someone at poster session yesterday, they say their main problem was that they want to hide the params pane while they are doing surgeries - gets in the way of the video.

@sneakers-the-rat
Copy link
Contributor Author

For reference, this is the acquisition window:

image

The window can't be resized once it's opened, but @fnsangiul says you can change the window size before clicking "run" by editing the windowScale parameter in the user config: ( eg. here:

). so that might help some things in the short term?

So things that might be nice here:

Make the window resizeable

the window is initialized here:

void VideoDevice::createView()

specifically:

view->setWidth(m_cDevice["width"].toInt() * m_ucDevice["windowScale"].toDouble(1));
view->setHeight(m_cDevice["height"].toInt() * m_ucDevice["windowScale"].toDouble(1));

Since windowScale is used there to change the window size without modifying the other qt widgets elsewhere, it seems like we should be able to just enable window resizing.

The default resizeMode makes the view object take the size of the root qml object: https://doc.qt.io/qt-6/qquickview.html#ResizeMode-enum
and the qml object then takes the width and height of the parent:

width: parent.width
height: parent.height
state: "controlsShown"

so I think we just need to set sizePolicy.Expanding on that item? idk i don't rly use or like qml/qtquick

move controls to a separate pane

currently the controls are overlaid on the image, which could get in the way. additionally important controls are hidden in the top drawer and not very discoverable. I think we should probably move those off to a panel on the side so they don't obscure the frame at all.

Also since ppl will be using this software while doing a surgery, we should probably also add hotkey bindings to some of the controls, particularly the focus plane, so people can mash at them without needing to use the mouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant