-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources including Linux icon, desktop file and AppStream metainfo #15
Comments
The resources dir is used for building the web version. The files used are quite large so I ended up not placing them in the repo. I am okay with just deleting the whole folder
A desktop file would be much welcome, but needs to be integrated into the install procedure to be useful I guess..
AppStream requires to keep the changelog and last release version on the xml file, which I don't think it is a good idea as it gives extra work to project maintainers and can't be automated in a non-spec-breaking way. So I am typically against it, as I already had the case in Carla where distros end up tweaking the AppStream xml file so they might as well generate it themselves.. |
for the resource folder, if needs to be deleted to be used for other purpose then I could use a different one, say I can include the resource changes in a first PR, adding in a second one the cmake install section, or just all in one PR, as you like. the releases section is not mandatory, I never add it for the reason you said, it's good to have the metainfo for some information and screenshots instead. |
Put desktop file in utils, icons can go in graphics if they are meant to be used by the runtime plugin or also in utils if it is a system-level integration thing alike macOS and Windows. |
FYI the resources dir is now gone from d8d4585 on |
Misc request about resources:
The text was updated successfully, but these errors were encountered: