Freedesktop resource files and related CMake install command #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I am skipping this part for the 1.0 release, as we want it out as soon as possible and I need to review+test some of these changes to go directly in DPF (still leaving a few, like desktop icon, on this repo) |
|
IDK what changes you plan to do but all the changes here were made to make easier the package creation (PKGBUILD in this case but can be used for other distros), they should not be moved away. |
|
installing the standalone and plugins should be done on dpf side, so all cmake based dpf plugins benefit from it. |
|
Oh, so this also takes part of the plugins group, IDK why I gave for grant that it was independent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the 256x256 png extracted from one of the ico/icns files, but can be replaced if needed. Closes #15.