Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check status of reqwest responses #72

Open
brson opened this issue Nov 26, 2022 · 0 comments
Open

Check status of reqwest responses #72

brson opened this issue Nov 26, 2022 · 0 comments

Comments

@brson
Copy link
Collaborator

brson commented Nov 26, 2022

It looks to me like we assume all reqwest responses are successful, though I haven't looked closely at the API to see how unsuccessdul requests are supposed to be handled.

Figure out the right way to deal with unsuccessful requests and change all the calls to return a proper error instead of blindly parsing the response as if it were a success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant