Explorer service crashing

[sebastian]

2020-07-29 12:20:01.720 [error] GenServer Air.Service.Explorer terminating
** (FunctionClauseError) no function clause matching in Air.Service.Explorer.handle_info/2
    (air) lib/air/service/explorer.ex:192: Air.Service.Explorer.handle_info({:ssl_closed, {:sslsocket, {:gen_tcp, #Port<0.49>, :tls_connection, :undefined}, [#PID<0.3972.0>, #PID<0.3971.0>]}}, false)
    (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Last message: {:ssl_closed, {:sslsocket, {:gen_tcp, #Port<0.49>, :tls_connection, :undefined}, [#PID<0.3972.0>, #PID<0.3971.0>]}}

This is running a version relatively close to master: https://github.com/Aircloak/aircloak/tree/jakub/feat/explorer-versioning

[gampleman]

Seems related to: benoitc/hackney#464. Can you post any more information re reproduction steps? What environment is this in? What version of Explorer?

[sebastian]

I got this when deploying the pull-request you sent me where you changed to using the version explorer API. At the time of writing Explorer was redeployed 3 hours ago, which should give us this version.

[sebastian]

I got the error above on sebastian-air when requesting to re-analyze all data sources. It then tried and failed to analyze all the data sources. Most failed with this explorer error, but then the error above popped in too.

[sebastian]

I am not sure if that will allow any reproduction, but if nothing else you have the signature of the unexpected error message that was sent to the gen server, so you could ensure you properly handle info messages and log unexpected ones...

[gampleman]

So you think the solution is to add a catch all handle_info and log? Is there much advantage to that as opposed to letting it crash and the supervisor restarting it?

[sebastian]

At least handle this particular error. We have seen it before. It's no reason to crash the server.