Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Note editing dialog for pending results disappears when the result completes. #4963

Open
cristianberneanu opened this issue Jul 19, 2021 · 3 comments

Comments

@cristianberneanu
Copy link
Member

When you add a note to a pending result, the dialog window disappears if the result completes in the meantime.
It might not worth fixing if the fix is too complex.

@cristianberneanu cristianberneanu added this to the Insights Evergreen milestone Jul 19, 2021
@edongashi
Copy link
Member

The modal must be hosted outside of the result to fix this. We can then provide a callback to children with a signature like this startNoteEditing(id, initialValue). The parent should handle managing the modal state.

@edongashi
Copy link
Member

But I'm wondering whether it's worth fixing...

@sebastian
Copy link
Member

Let's not fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants