Update remote.cpp to allow parsing JSON over ESP NOW #4084
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazoncek
requested changes
Aug 2, 2024
wled00/remote.cpp
Outdated
| uint8_t byte11; // Unknown, maybe checksum | ||
| uint8_t byte12; // Unknown, maybe checksum | ||
| uint8_t byte13; // Unknown, maybe checksum | ||
| uint8_t program; |
There was a problem hiding this comment.
why did you remove helpful comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little change has allowed me to send a JSON over ESPNow and it works well.
{ "command":{ "on": true, "bri": 100, "seg": [ { "col": [[128, 0, 128]], "fx": 0 } ] }, }I am not very mature with codes and need someone to peer review the change.