-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ETH support for the cod.m WLED LAN Controller #4160
Conversation
There are no differences to the existing ESP32-POE Ethernet type. Why a new one?
|
If a customer of us will reset the controller it's easier to find the correct config. |
Instead of adding a duplicate config, it's better to update the existing UI dropdown entry. Case solved 😉 |
These were added at the time when space was not yet at premium (more than 3 years ago). Unfortunately removing them is a breaking change that may render devices unreachable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new type is only justified if it differs in HW configuration.
@blazoncek can we rename the option as @softhack007 suggested ? |
I'm afraid this will lead nowhere. IMO provide a user manual where it is clearly stated that your board uses "ESP32-POE" ethernet adapter. |
Added ethernet configuration for the upcoming cod.m WLED LAN Controller.