Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle timestamp types in backups #779

Open
1 task
matyaskuti opened this issue Dec 12, 2023 · 0 comments
Open
1 task

Handle timestamp types in backups #779

matyaskuti opened this issue Dec 12, 2023 · 0 comments

Comments

@matyaskuti
Copy link
Contributor

matyaskuti commented Dec 12, 2023

What is currently missing?

Prompted by a discussion on a PR replacing Kafka consumer implementations with confluent-kafka, it turns out we do not back up the timestamp types of messages/records. (The kafka-python library had this as a separate field ConsumerRecord.timestamp_type; confluent-kafka has a 2-tuple for Message timestamps.)

How could this be improved?

  • Should timestamp types be backed up and restored?
  • The implementation seems relatively straightforward, the current timestamps could be extended with the type

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant