Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new tests to improve coverage of exposed metrics. #219

Open
lukas-vlcek opened this issue Aug 31, 2023 · 0 comments
Open

Implement new tests to improve coverage of exposed metrics. #219

lukas-vlcek opened this issue Aug 31, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@lukas-vlcek
Copy link
Collaborator

When new metrics are introduced in OpenSearch we do not learn about this when upgrading. There is simply no logic to automatically detect this and those new metric stay unnoticed.

To improve this situation we can implement a new set of tests that will pull JSON data containing metrics and count number of members of the JSON structure and compare to hard-coded numbers. This way we can easily learn that something new was added. Theoretically we can miss the case when one metric is removed and one added (the count will be the same) but this will be caught by other existing tests that "call specific metrics by name".

@lukas-vlcek lukas-vlcek added the good first issue Good for newcomers label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant