Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate the approximate "cost" in SC #36

Open
Akuukis opened this issue Aug 16, 2020 · 1 comment
Open

calculate the approximate "cost" in SC #36

Akuukis opened this issue Aug 16, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Akuukis
Copy link
Owner

Akuukis commented Aug 16, 2020

Is your feature request related to a problem? Please describe.

Calculate the approximate "cost" in SC.

Describe the solution you'd like

I was wondering if you think it might one day be possible to check the components list vs the average cost of components from the trade stations, and calculate the approximate "cost" in SC of a given blueprint. Just a suggestion, i'd love to see it!

Additional context

Copied from DM.

@Akuukis Akuukis added the enhancement New feature or request label Aug 16, 2020
@Akuukis
Copy link
Owner Author

Akuukis commented Aug 16, 2020

Seems straightforward to do. Some thoughts on how to implement that

1. Get prices

  1. make a JSON datafile with prices somewhere in praisal/vendor folder. Structure may be a object where keys are component subtypes and values are the prices. Make an interface for it.
  2. The most tricky part of this - make some methodology to get the numbers and write it down in README or elsewhere, so that later we can follow it to update the prices. . Bonus points for automated bash script that does the whole thing.
  3. Get the numbers.

2. Make SEPraisal to know the price of each component

  1. look where PraisalManager.addComponentsSbc is used and pass the content of databse that just like the sbc file is. And change the params of it to take such an object with such an interface.
  2. add componentPrice to IParseComponentSbc and parseComponentSbc
  3. add componentPrice to IComponentDTO and Component

3. Make SEPraisal to report the price of the whole blueprint

  1. add componentPrice to IBlueprint.IMaterialGroupFull next to componentMass and others. IBlueprint.ISbc extends that.
  2. add componentPrice to Praisal similar to componentMass.
  3. add componentPrice to Praisal.toBlueprintSbc function.

@Akuukis Akuukis added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant