Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show in browse unpraised blueprints too #7

Open
2 tasks
Akuukis opened this issue Jun 4, 2020 · 1 comment
Open
2 tasks

show in browse unpraised blueprints too #7

Akuukis opened this issue Jun 4, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Akuukis
Copy link
Owner

Akuukis commented Jun 4, 2020

Is your feature request related to a problem? Please describe.

Neil Ward commented on the Facebook post:

Doesn't really work properly- I know for a fact there are a lot of large ships it's missing for some reason ( when you search by size, largest first essentially ). I know, because I built them- it's got one of mine in there, but it's missing several others. 5/10 interesting tool, needs refinement to be truly useful. EDIT: they don't even show up when searching by name, really need to sort the tool out...

Describe the solution you'd like

  • Don't filter out unpraised blueprints by default.
  • In the browse card instead of 4 main stats, write "Unpraised", perhaps with a explanation too (from sbc._error).
@Akuukis Akuukis added enhancement New feature or request good first issue Good for newcomers labels Jun 4, 2020
@Akuukis
Copy link
Owner Author

Akuukis commented Aug 21, 2020

Problem No.2

When upgrading version it takes 2-3 days to re-praise everything. Unfortunately there's no way for users to understand that's expected instead of "bah this website is missing so many blueprints".

Solution

Just like above, leave them searchable and present with a understandable error on a card. The difference - handle the case where there's no sbc._error but also sbc_version < IBlueprint.VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant