Rerouted departure and arrival stations are displaying inverted #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusnaughton
added
Type: Bug
jason-capsule42
force-pushed
the
naughton/reroutedisplayfixes
branch
2 times, most recently
from
caf45e6 to
b787aaf
Compare
jason-capsule42
force-pushed
the
naughton/reroutedisplayfixes
branch
from
b787aaf to
f88d820
Compare
jason-capsule42
force-pushed
the
naughton/reroutedisplayfixes
branch
from
f88d820 to
43706b6
Compare
jason-capsule42
approved these changes
Aug 8, 2024
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
In the docs, the rerouted station is flipped. The originally intended airport (departureStation/arrivalStation) is in plaintext, but the rerouted station is with strikethrough. The logic here is inverted.
Resolves: #123
Summary:
I have refined the render function logic to display the strikethrough class correctly. Additionally, I have bolstered the test cases to ensure this does not regress again in the future.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team