-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase beta off main in preparation for release #128
Conversation
|
6a3dbcc
to
07f806e
Compare
Reviewer's Guide by SourceryThis pull request primarily addresses conflicts and makes minor adjustments to the auro-flight component. The changes include updating file paths, fixing display issues with rerouted stations, adjusting ESLint configurations, and making small updates to the README and CHANGELOG. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
fea9829
to
25c35ce
Compare
Somehow, this repo was missing a lot of the new build scripts, and was not able to generate a new README or other docs. This commit adds those sans the `build:version` script as we did not need that for this repo. Changes to be committed: modified: demo/api.html modified: package.json
25c35ce
to
d4f0613
Compare
🎉 This PR is included in version 2.8.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Summary:
Rebasing the beta branch off main to get it ready for release
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix display issues with rerouted departure and arrival stations in the auro-flight component, update documentation for consistency, and enhance tests to cover the new display logic. Adjust ESLint rules to better handle magic numbers and array indexes.
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores: