Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase beta off main in preparation for release #128

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

DukeFerdinand
Copy link
Contributor

@DukeFerdinand DukeFerdinand commented Aug 19, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Summary:

Rebasing the beta branch off main to get it ready for release

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other - rebase

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix display issues with rerouted departure and arrival stations in the auro-flight component, update documentation for consistency, and enhance tests to cover the new display logic. Adjust ESLint rules to better handle magic numbers and array indexes.

Bug Fixes:

  • Fix rerouted departure and arrival stations to display correctly in the auro-flight component.

Enhancements:

  • Improve the handling of rerouted stations by adjusting the HTML structure to ensure proper display of line-through styling.

Documentation:

  • Update README.md to correct formatting and ensure consistent spacing throughout the document.

Tests:

  • Update tests for auro-flight-main to verify the correct display of rerouted departure and arrival stations.

Chores:

  • Modify ESLint configuration to adjust rules for ignoring magic numbers and array indexes.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ gusnaughton
✅ jason-capsule42
✅ jordanjones243
✅ DukeFerdinand
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@DukeFerdinand DukeFerdinand force-pushed the dhook/fix-beta-conflicts branch from 6a3dbcc to 07f806e Compare August 19, 2024 18:00
@DukeFerdinand DukeFerdinand marked this pull request as ready for review August 19, 2024 18:42
@DukeFerdinand DukeFerdinand requested a review from a team as a code owner August 19, 2024 18:42
Copy link

sourcery-ai bot commented Aug 19, 2024

Reviewer's Guide by Sourcery

This pull request primarily addresses conflicts and makes minor adjustments to the auro-flight component. The changes include updating file paths, fixing display issues with rerouted stations, adjusting ESLint configurations, and making small updates to the README and CHANGELOG.

File-Level Changes

Files Changes
README.md Updated README.md with minor formatting changes and version updates
src/auro-flight-main.js Fixed display of rerouted departure and arrival stations in the component
CHANGELOG.md Updated CHANGELOG.md to reflect bug fix instead of new feature
test/auro-flight-main.test.js Modified tests to check for correct content in rerouted station spans
eslint.config.mjs Adjusted ESLint configuration for magic numbers
demo/api.html Updated API documentation fetch path

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DukeFerdinand - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/auro-flight-main.js Show resolved Hide resolved
test/auro-flight-main.test.js Show resolved Hide resolved
test/auro-flight-main.test.js Show resolved Hide resolved
test/auro-flight-main.test.js Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the dhook/fix-beta-conflicts branch from fea9829 to 25c35ce Compare August 19, 2024 18:54
Somehow, this repo was missing a lot of the new build scripts, and was not able to generate a new README or other docs.

This commit adds those sans the `build:version` script as we did not need that for this repo.

Changes to be committed:
	modified:   demo/api.html
	modified:   package.json
@jason-capsule42 jason-capsule42 force-pushed the dhook/fix-beta-conflicts branch from 25c35ce to d4f0613 Compare August 19, 2024 19:01
@jason-capsule42 jason-capsule42 changed the title Dhook/fix beta conflicts Rebase beta off main in preparation for release Aug 19, 2024
@jason-capsule42 jason-capsule42 merged commit b6d6ee8 into beta Aug 19, 2024
3 of 4 checks passed
@jason-capsule42 jason-capsule42 deleted the dhook/fix-beta-conflicts branch August 19, 2024 19:06
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.8.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants