Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support smaller font sizes on mobile #55

Closed
cwilliams7 opened this issue Mar 30, 2023 · 8 comments · Fixed by #96
Closed

Support smaller font sizes on mobile #55

cwilliams7 opened this issue Mar 30, 2023 · 8 comments · Fixed by #96
Assignees
Labels
auro-flight not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@cwilliams7
Copy link

Is your feature request related to a problem? Please describe.

The design team for Merch has a design for a mobile flight card that uses size 1.125rem font for the departure and arrival times:

image

The auro-flight component uses 1.75rem for these fonts and it cannot be adjusted directly.

image

Describe the solution you'd like

I'd like the component either updated to allow for an input to control the mobile font size, with the default value being the same as today for backward compatibility or have the component updated to use 1.125rem for departure & arrival times on mobile screen sizes, there was some discussion on the Auro public channel that the behavior I am seeing might be a bug and the font size is supposed to be 1.125rem on mobile.

Describe alternatives you've considered

I considered using javascript to reach into the shadow dom and modify the styles directly but this would be a brittle solution and doesn't address the underlying issue.

@cwilliams7 cwilliams7 added auro-flight not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Mar 30, 2023
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes and removed auro-flight labels Mar 31, 2023
@blackfalcon blackfalcon removed their assignment Mar 31, 2023
@blackfalcon
Copy link
Member

Hey @cwilliams7 I am looking over the code for this element and we do not have any media query support. I am re-classing this as a FEATURE vs a BUG as this is not something that is broken, it's a capability that does not exist.

@leeejune who is a designer we can work with to understand the missing capability?

@blackfalcon blackfalcon added auro-flight and removed Type: Bug Bug or Bug fixes labels Apr 5, 2023
@leeejune
Copy link

leeejune commented Apr 5, 2023

@blackfalcon Not sure who the designer is. @cwilliams7 who can I reach out to?

@cwilliams7
Copy link
Author

@blackfalcon, thanks for clarifying! @blackfalcon & @leeejune the designer would be Chloe L'Ecuyer.

@leeejune
Copy link

leeejune commented Sep 1, 2023

Erika has also brought this issue up. Would like to see this work refined.

@erikalanghauser
Copy link
Member

Flight Search is planning to direct mobile user to the responsive microsite soon, and we are seeing the same wrapping issue with the time. The auro-flight blueprint does indicate smaller text sizes at the mobile breakpoint.

@leeejune
Copy link

leeejune commented Sep 2, 2023

@braven112
Copy link
Member

We need to update the smallest breakpoint to use var(--auro-text-heading-300-size-breakpoint-sm)

blackfalcon pushed a commit that referenced this issue Oct 30, 2023
## [2.4.1](v2.4.0...v2.4.1) (2023-10-30)

### Bug Fixes

* **font:** make departure/arrival time mobile font smaller [#55](#55) ([bbfd5bf](bbfd5bf))
@leeejune
Copy link

leeejune commented Dec 6, 2023

Blueprint completed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-flight not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants