Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of attributes may be causing JS error #206

Open
blackfalcon opened this issue May 30, 2024 · 0 comments
Open

Combination of attributes may be causing JS error #206

blackfalcon opened this issue May 30, 2024 · 0 comments

Comments

@blackfalcon
Copy link
Member

Please verify the version of auro-hyperlink you have installed

@latest

Please describe the bug

Content containing an auro-hyperlink with both the relative and target="_blank" attributes caused an error on the page.

Reproducing the error

This issue cannot be reproduced on the Auro docsite

Expected behavior

It is assumed that using both attributes should not cause an error.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

See this commit:

AlaskaAirlines/AuroDocsSite@e9ce9e6

These updates modify the auro-hyperlink target attribute references to resolve an issue on the home and Support pages where the UI was unresponsive on render.

This issue may be a bug with auro-hyperlink when relative and target are used on the same anchor tag.

While updating the Auro Doc Site, an issue was discovered on the Home and Support pages where the left navigation scrolling and all links were unusable.

Both pages contain FAQ content. In the question "Q: Does Auro support React, Svelte, Vue, etc.?" there were two links that contained both the relative and target="_blank" attributes. It was discovered that removing the target="_blank" attribute resolved the issue.

It is currently undetermined if this issue appears in the Lit element development environment, as there is no current demo of this use, or if it is specific to the auro-hyperlink and the doc site.

Exit criteria

This issue can be closed once it is determined whether the bug is with the element itself or specific to the Auro doc site. Once identified, appropriate actions will be taken to address the issue.

@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members Question Further information is requested labels May 30, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment May 30, 2024
@Patrick-Daly-AA Patrick-Daly-AA added Type: Perf Performance update to existing code and removed not-reviewed Issue has not been reviewed by Auro team members labels May 30, 2024
@jason-capsule42 jason-capsule42 removed Type: Bug Bug or Bug fixes Question Further information is requested Type: Perf Performance update to existing code labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants