Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-icon still using tier 1 tokens #146

Open
jordanjones243 opened this issue Oct 25, 2024 · 2 comments
Open

auro-icon still using tier 1 tokens #146

jordanjones243 opened this issue Oct 25, 2024 · 2 comments
Assignees

Comments

@jordanjones243
Copy link
Contributor

Please verify the version of auro-icon you have installed

5.0.2

Please describe the bug

  1. Go to https://github.com/AlaskaAirlines/auro-icon/blob/master/src/style.scss
  2. See error on line 24 (--ds-color-brand-midnight-400)
  3. Go to https://github.com/AlaskaAirlines/auro-icon/blob/master/src/alaskaStyle.scss
  4. See error on line 26 (--ds-color-base-white)

Reproducing the error on the docsite

This issue cannot be reproduced on the Auro docsite

Expected behavior

Tier 3 semantic tokens should be created as aliases for these tokens

What browsers are you seeing the problem on?

No response

Additional context

Tier 3 semantic tokens should be used within every component in Auro

Exit criteria

Tier 3 semantic tokens should are created as aliases for these tokens

@jordanjones243 jordanjones243 added Type: Bug Bug or Bug fixes auro-icon not-reviewed Issue has not been reviewed by Auro team members labels Oct 25, 2024
@jason-capsule42 jason-capsule42 removed Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Oct 27, 2024
@jason-capsule42
Copy link
Member

Note that both of these colors are for the Alaska Logo. Does that mean they should remain as tier 1?

@Patrick-Daly-AA
Copy link

Question for @leeejune , do we foresee ever needing/wanting to make the colors in the logo theme-able? Should be just add some Tier 2 "brand only" color tokens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants