Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-icon: Resize Icon When Label Exists #89

Open
rallyb13 opened this issue Jun 15, 2023 · 3 comments
Open

auro-icon: Resize Icon When Label Exists #89

rallyb13 opened this issue Jun 15, 2023 · 3 comments

Comments

@rallyb13
Copy link

Is your feature request related to a problem? Please describe.

The customSize attribute works great to resize, but only when there's no label.
Because it targets the parent element rather than the icon itself, any resize attempt ends up targeting the label as well. Which means that a) the icon itself does not resize & b) the label text has CSS applied that I don't want.

Screenshot 2023-06-15 at 10 40 18 AM

Describe the solution you'd like

The ability to target the icon only while also using a label.

Describe alternatives you've considered

When used transform: scale, which only works because we conveniently wanted the font-size to differ by the same proportion.

Additional context

No response

@rallyb13 rallyb13 added auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Jun 15, 2023
@blackfalcon
Copy link
Member

@rallyb13 you are correct. The ability to resize never considered its association with the label content.

@Patrick-Daly-AA This is a viable feature we should add to this element. @rallyb13 do you have availability to contribute to this update?

@Patrick-Daly-AA
Copy link

Assigning to @leeejune for input on if this is compliant with our design, or if the design needs to be updated to accommodate this.

@rallyb13
Copy link
Author

@rallyb13 do you have availability to contribute to this update?
Not in the immediate future, I'm afraid. If it still hasn't been picked up after the hackathon, then maybe...?

@jason-capsule42 jason-capsule42 removed Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants