Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons are not centered for each sidenav option #17

Closed
jordanjones243 opened this issue Feb 28, 2024 · 2 comments · Fixed by #23
Closed

Icons are not centered for each sidenav option #17

jordanjones243 opened this issue Feb 28, 2024 · 2 comments · Fixed by #23
Assignees
@rsstdd @DukeFerdinand
Labels
auro-sidenav released Completed work has been released Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Feb 28, 2024 •
edited by Patrick-Daly-AA
Loading

Please verify the version of auro-sidenav you have installed

1.1.6

Please describe the bug

  1. Go to https://auro.alaskaair.com/components/auro/sidenav
  2. See default example
  3. See icons not centered vertically

Reproducing the error

None

Expected behavior

All icons are vertically centered within their respective parent elements

What browsers are you seeing the problem on?

Chrome

Exit criteria

All icons are centered
@jordanjones243 jordanjones243 added auro-sidenav not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Feb 28, 2024
@jordanjones243 jordanjones243 self-assigned this Feb 28, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Mar 5, 2024
@Patrick-Daly-AA
Copy link

This could be an issue where the shape of the svg is getting elongated in the HTML and thus isn't being centered properly when embedded

@rsstdd rsstdd mentioned this issue Mar 19, 2024
Merged
3 tasks
@rsstdd rsstdd linked a pull request Mar 19, 2024 that will close this issue
fix(svg): center svgs within sidenavitems #23
Merged
3 tasks
rsstdd added a commit that referenced this issue Mar 22, 2024
@rsstdd
fix(svg): center svgs within sidenavitems #17
20467d9 
Previously, SVGs were assigned a style top: -4px. This was causing the
SVGs to be misaligned within the parent. This commit removes the
top: -4px style from the SVGs.

Closes #17

Changes to be committed:
	modified:   src/style-items.scss
rsstdd added a commit that referenced this issue Mar 22, 2024
@rsstdd
fix(svg): center svgs within sidenavitems #17
38e4a32 
Previously, SVGs were assigned a style top: -4px. This was causing the
SVGs to be misaligned within the parent. This commit removes the
top: -4px style from the SVGs.

Closes #17

Changes to be committed:
	modified:   src/style-items.scss
jordanjones243 pushed a commit that referenced this issue Mar 25, 2024
@rsstdd @jordanjones243
fix(svg): center svgs within sidenavitems #17
86536e6 
Previously, SVGs were assigned a style top: -4px. This was causing the
SVGs to be misaligned within the parent. This commit removes the
top: -4px style from the SVGs.

Closes #17

Changes to be committed:
	modified:   src/style-items.scss
blackfalcon pushed a commit that referenced this issue Mar 25, 2024
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
e866338 
# [2.0.0](v1.1.7...v2.0.0) (2024-03-25)

### Bug Fixes

* **svg:** center svgs within sidenavitems [#17](#17) ([364db92](364db92))

### Features

* mobile sidenav via attribute [#13](#13) ([c88af64](c88af64))

### BREAKING CHANGES

* all auro-sidenav instances are now mobile until
specified with the static attribute.

Changes to be committed:
	modified:   apiExamples/basic.html
	modified:   apiExamples/custom.html
	modified:   apiExamples/full.html
	modified:   apiExamples/heading.html
	modified:   apiExamples/hyperlink.html
	modified:   apiExamples/isToggle.html
	modified:   apiExamples/sections.html
	modified:   apiExamples/selected.html
	modified:   demo/api.md
	modified:   demo/index.html
	modified:   demo/index.md
	modified:   docs/api.md
	modified:   docs/partials/index.md
	modified:   package-lock.json
	modified:   src/auro-sidenav.js
	modified:   src/auro-sidenavsection.js
	modified:   test/auro-sidenav.test.js
   modified:   apiExamples/collapsible.html
   modified:   README.md
@blackfalcon
Copy link
Member

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsstdd rsstdd

@DukeFerdinand DukeFerdinand

Labels
auro-sidenav released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(svg): center svgs within sidenavitems AlaskaAirlines/auro-sidenav
5 participants
@blackfalcon @rsstdd @DukeFerdinand @jordanjones243 @Patrick-Daly-AA