-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Michael/feature/docker files and containers - V1 of Docker development environment #50
base: main
Are you sure you want to change the base?
Conversation
…ate_packet() into update_packet()
…itor. I have finished the Docker container, it is ready to go, I also included some bash scripts to run it. I suggest running it from a Linux VM or install as that is how I have set everything up.
container. Able to access repo from within the container. Still working on commit prompts on for exit/entry from/into the container
….com/AlbertaSat/ex3_simulated_subsystems into tomasz/feature/add_dfgm_data
…aSat/ex3_simulated_subsystems into Ben/feature/create_simulated_iris
…system_final_final Ben/feature/iris simulated subsystem final final
…itor. I have finished the Docker container, it is ready to go, I also included some bash scripts to run it. I suggest running it from a Linux VM or install as that is how I have set everything up.
container. Able to access repo from within the container. Still working on commit prompts on for exit/entry from/into the container
…f of local files instead of remote host ones
…com:AlbertaSat/ex3_simulated_subsystems into michael/feature/docker_files_and_containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Sorry this took so long to review.
Its been a while and main has changes a decent bit so be sure to pull main into this branch before pushing any more commits.
I think the next step is to setup the UHF simulated subsystem (Drake has been working on this) to talk with an exposed port, so the GS backend can be run outside the container - "on the ground" - and everything that would be on board the SC runs inside the container. As well we want to run the OBC FSW rust processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please flush this out a little more with brief explanation of how to actually use the docker container (how to talk to the sim subsystems started) - many members will not be familiar with docker so it will be good to make this as straightforward as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a placeholder ?
Also please modify your python t o either pass the pylint check or add pylint ignore decorators as needed. |
This is a completed version of the Docker environment I have been working on. Now I will be working on a version with docker compose for dev that copies in the local repository and storing changes locally instead of using the users ssh keys to access the remote.