Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark notifications as read when the corresponding action is performed #147

Open
AlbertoPdRF opened this issue Jun 26, 2020 · 0 comments
Open
Labels
enhancement Related to improvements of existing features and/or addition of new ones full stack Requires work on both the front and back ends of the application

Comments

@AlbertoPdRF
Copy link
Owner

AlbertoPdRF commented Jun 26, 2020

Right now, almost all the the notifications are marked as read when the page they link to is visited, but it would be better to mark them as read when the corresponding action is performed (if it makes sense, as there can be cases where it's better to leave the current behavior). The only notification that currently behaves like this is the email confirmation one.

An example: the initial notification that asks the user to upload an avatar gets marked as read when the user visits /users/:userId/edit, but it would be better to mark it as read when the user actually uploads an avatar.

@AlbertoPdRF AlbertoPdRF added the enhancement Related to improvements of existing features and/or addition of new ones label Jun 26, 2020
@AlbertoPdRF AlbertoPdRF added the full stack Requires work on both the front and back ends of the application label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Related to improvements of existing features and/or addition of new ones full stack Requires work on both the front and back ends of the application
Projects
None yet
Development

No branches or pull requests

1 participant