Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the welcome and about pages #304

Open
AlbertoPdRF opened this issue Sep 21, 2020 · 4 comments
Open

Merge the welcome and about pages #304

AlbertoPdRF opened this issue Sep 21, 2020 · 4 comments
Assignees
@ch374n
Labels
design Make things look nicer enhancement Related to improvements of existing features and/or addition of new ones front end Requires work on the front end of the application good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants high priority Needs to be taken care of as soon as possible! refactor Improve the code of existing features

Comments

@AlbertoPdRF
Copy link
Owner

Is your feature request related to a problem? Please describe.

The welcome page is quite ugly and empty at the moment, and it's main call to action drives users to the about page. The about page will hopefully be way more visually appealing after #303, and it already has a call to action to drive users to register, so merging both will hopefully improve our user conversion rates!

Describe the solution you'd like

I'd like the welcome and about pages to be merged into one, but also keep serving the About component on the /about route for logged in users to be able to see it.

Describe alternatives you've considered

Leave everything as is.

Additional context

None.
@AlbertoPdRF AlbertoPdRF added enhancement Related to improvements of existing features and/or addition of new ones refactor Improve the code of existing features design Make things look nicer front end Requires work on the front end of the application labels Sep 21, 2020
@AlbertoPdRF AlbertoPdRF added the high priority Needs to be taken care of as soon as possible! label Oct 8, 2020
@ch374n
Copy link

ch374n commented Oct 14, 2020

hey, I would like to work on this one. can you please give some detailed information ? thank you.

@AlbertoPdRF
Copy link
Owner Author

Hi @ch374n, welcome to our repository and thanks for your interest on this issue! 🙌

Here's a more detailed explanation of what this issue is about: right now we have a Welcome component that gets rendered as the landing page for non-signed up/logged in users. We also have an About component that gets rendered whenever anyone visits the /about route. The idea is to render the About component inside the Welcome one -- making the necessary adjustments so we end up having a nice landing page --, but also keep rendering the standalone About component when logged in users visit the /about route.

I hope that's a bit clearer! 🙂 But if you need anything else, don't hesitate to ask! And you can also join our Slack workspace, for which you can find an invite link on the README.

If you want to work on the issue, just let me know and I'll assign it to you! 👀

@ch374n
Copy link

ch374n commented Oct 14, 2020

Okay then assign me

@AlbertoPdRF
Copy link
Owner Author

Done! 😃

@AlbertoPdRF AlbertoPdRF added good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch374n ch374n

Labels
design Make things look nicer enhancement Related to improvements of existing features and/or addition of new ones front end Requires work on the front end of the application good first issue Good for newcomers hacktoberfest Recommended issues for hacktoberfest participants high priority Needs to be taken care of as soon as possible! refactor Improve the code of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlbertoPdRF @ch374n