Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better readme #6

Open
ganego opened this issue Apr 17, 2022 · 3 comments
Open

Better readme #6

ganego opened this issue Apr 17, 2022 · 3 comments

Comments

@ganego
Copy link

ganego commented Apr 17, 2022

Hi, I just installed your tool and I think the readme should be improved.

  • You state "adb (binary) should exist in project root folder". It's unclear from the doc what this is, since when getting the source zip, the root folder is the one with the readme.md file. Having adb there does not work, it needs to be in the src folder.
  • You state one should use adb binary. You do not write, that I have to uncomment adb.set_core(Adb.EXTERNAL_TOOL_ADB) to do that. Also I was under the impression I would not have to install adb-shell when using adb binary, yet I have to do that. Please write in the readme, that you have to uncomment that line, or build something that autodetects adb binary or let one choose from within the program.

Thank you

@SmartManoj
Copy link

SmartManoj commented Oct 10, 2022

You could open a PR.

@fourofspades
Copy link

documentation is really poor. I gave up, poor documentation is likely a sign of poor code.

@dandv
Copy link
Contributor

dandv commented Mar 21, 2023

Looks like re repo is abandoned. You need to run this command then refer to the README I patched via #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants