Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle accepted task handoff for verifiers #305

Closed
jules opened this issue Jul 15, 2021 · 2 comments · Fixed by #352
Closed

Handle accepted task handoff for verifiers #305

jules opened this issue Jul 15, 2021 · 2 comments · Fixed by #352
Assignees
Labels
bug Something isn't working

Comments

@jules
Copy link

jules commented Jul 15, 2021

While testing for #252, I noticed that my test failed due to the pending task not having any way of being reassigned, as there were no verifiers left. This doesn't seem to be a problem in any of the other timeout tests, which seems like a bug to me - those tasks still should be handed off, but they apparently just kind of disappear.

The drop_participant logic should be updated so that all verifier tasks are handed off properly.

@kellpossible
Copy link

More generally we should test what happens when verifiers are dropped from the ceremony at least in the integration tests, and ensure that it doesn't stall

@kellpossible kellpossible mentioned this issue Jul 17, 2021
7 tasks
@kellpossible
Copy link

kellpossible commented Jul 17, 2021

This line should be investigated more: #288 (comment) perhaps as part of this issue.

@apruden2008 apruden2008 added this to the Universal Setup milestone Jul 20, 2021
@apruden2008 apruden2008 added the bug Something isn't working label Jul 20, 2021
jules added a commit that referenced this issue Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants