Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor storage access logic to use only [Locator] instead of either [Locator] or [LocatorPath] #306

Open
apruden2008 opened this issue Jul 15, 2021 · 3 comments
Open

Refactor storage access logic to use only [Locator] instead of either [Locator] or [LocatorPath] #306

apruden2008 opened this issue Jul 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@apruden2008
Copy link

Round restart PR #288 uses a locator_or_path enum for removing chunks. In the future, this could be refactored using only the Locator struct. See inline comment: https://github.com/AleoHQ/aleo-setup/pull/288/files#r670566403
@apruden2008 apruden2008 added the enhancement New feature or request label Jul 15, 2021
@apruden2008
Copy link
Author

@kellpossible can you extrapolate on this if needed?

@kellpossible
Copy link

The code currently has an enum for working with both Locator and LocatorPath. There are parts of the code that the changes in #288 depend on that work with LocatorPath, these can probably be refactored to use Locator instead, rendering this LocatorOrPath enum redundant.

@kellpossible
Copy link

Using Locator instead also has the benefit of being a bit more type safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellpossible @apruden2008