Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make print output to the screen #17

Open
aaronfreed opened this issue Jul 6, 2024 · 4 comments
Open

Make print output to the screen #17

aaronfreed opened this issue Jul 6, 2024 · 4 comments
Labels
difficulty: kindergarten Expected to be pretty easy and simple. Very suited for a beginner contributor. type: enhancement New feature or request

Comments

@aaronfreed
Copy link
Contributor

aaronfreed commented Jul 6, 2024

Corollary of #16 – print (as opposed to Players.print) should output to the screen, to the command line, and to the log by default.

@SolraBizna SolraBizna added type: enhancement New feature or request difficulty: kindergarten Expected to be pretty easy and simple. Very suited for a beginner contributor. labels Jul 7, 2024
@SolraBizna
Copy link
Member

I would want there to still be a way for Lua code to output to the log (or stdout, which is the log) on purpose.

@aaronfreed
Copy link
Contributor Author

aaronfreed commented Jul 8, 2024

Right. My proposed behavior is for it to output to three locations by default:

  1. The screen.
  2. The command line.
  3. The log / stdout.

Stretch goal: Option for timestamped log files with the date and time the app was launched (in ISO 8601 format, of course). On Windows, the app currently overwrites existing log files, which I’ve worked around by using a batch file that timestamps the filename. I’ve come to prefer this approach because it stops log files from being frontloaded with a bunch of stuff that’s no longer directly relevant.

@SolraBizna
Copy link
Member

The "command line output" is stdout. On Windows and macOS, the engine redirects stdout to a log file.

@aaronfreed
Copy link
Contributor Author

Ah, that makes sense. In any case, I think the ideal behavior would be for it to output both to the screen and to stdout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: kindergarten Expected to be pretty easy and simple. Very suited for a beginner contributor. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants