Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FTP operations to a single function #59

Open
fccoelho opened this issue Nov 5, 2021 · 3 comments
Open

Refactor FTP operations to a single function #59

fccoelho opened this issue Nov 5, 2021 · 3 comments

Comments

@fccoelho
Copy link
Collaborator

fccoelho commented Nov 5, 2021

Many of our modules replicate basic ftp file retrieval operations
We should remove all the duplication of code by creating a single function for retrieving files through FTP.
this function should most likely belong to an ftptools module in the utilities package.

@anapaulagomes
Copy link

Is this issue still valid?

@fccoelho
Copy link
Collaborator Author

Thanks for asking. I don't think so. @luabida has done a big refactoring of the FTP interface. @luabida, can we close this one as stale?

@luabida
Copy link
Collaborator

luabida commented Jul 31, 2024

Thanks for asking. I don't think so. @luabida has done a big refactoring of the FTP interface. @luabida, can we close this one as stale?

I guess so. This is the only method responsible for accessing the DATASUS ftp server after the refactor, any special error cases should be handled in its try except block. Currently, the purpose of the try block is to close the ftp connection if any error happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants