Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes doesn't split on Oblobbles in P5 #97

Open
AlexKnauth opened this issue Aug 17, 2024 · 0 comments
Open

Sometimes doesn't split on Oblobbles in P5 #97

AlexKnauth opened this issue Aug 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AlexKnauth
Copy link
Owner

AlexKnauth commented Aug 17, 2024

In 3 P5 runs (of many more), it stopped splitting around Oblobbles.

In 2 of them, it didn't split the transition from Oblobbles to Sisters. In 1 of them, it didn't split the transition from Soul Master to Oblobbles.

So something is broken around Oblobbles. Of the 3 times it broke, 1 of them was going into Oblobbles, and 2 of them it was going out of Oblobbles.

Code in the WASM autosplitter:

        Split::SoulMasterP => should_split(p.old.starts_with("GG_Soul_Master") && p.current.starts_with("GG_Oblobbles")),
        Split::OblobblesP => should_split(p.old.starts_with("GG_Oblobbles") && p.current.starts_with("GG_Mantis_Lords")),

Code in the Default autosplitter:

                case SplitName.SoulMasterP: shouldSplit = sceneName.StartsWith("GG_Soul_Master") && nextScene.StartsWith("GG_Oblobbles"); break;
                case SplitName.OblobblesP: shouldSplit = sceneName.StartsWith("GG_Oblobbles") && nextScene.StartsWith("GG_Mantis_Lords"); break;

Is there another scene being loaded that might be confusing it like Oblobbles_boss or something that wouldn't fit under starts_with("GG_Oblobbles")?

@AlexKnauth AlexKnauth added the bug Something isn't working label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant