New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all the implementation classes #105

Open

AlexMathew opened this issue Apr 19, 2018 · 0 comments

Assignees

Labels

codeclimate enhancement

Owner

AlexMathew commented Apr 19, 2018

2015 me wrote horrible OO code.

Actually properly use inheritance in the classes. Why is this needed?

Helps get rid of a major load of code duplication
Forces to break functions down - so decreasing the cognitive complexity of the implementation functions.

AlexMathew self-assigned this

AlexMathew added enhancement codeclimate labels

AlexMathew mentioned this issue

Refactor selector classes #106

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment