-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that merged object counts are stored as sparse dgCMatrix #289
Comments
Do we have a sense of what effect this will have on runtime? I don't really have a sense either way but I can dream that maybe making this sparse could help! |
I think it will actually slow down any scripts that use this function since the conversion itself can take some time. Working with a dataset that has 13 samples this took 30 seconds or so, and I can imagine it might be longer on bigger objects. But it does decrease the size of the counts matrix. I saw about a 20% reduction in size in the matrix itself when storing as |
Yeah, I was also thinking about time to write the file, so maybe things even out! |
Just noting that we should use the more general |
We should also maybe test setting Either change will likely increase memory usage for the script, so we may need to be cognizant of how it may affect our ability to merge large objects. |
When working with the merged objects, I noticed that the counts matrix wasn't quite the correct format. It looks we are storing a
DelayedMatrix
instead of adgCMatrix
. I think we want to match what's typically in aSingleCellExperiment
object, which would be adgCMatrix
. I don't think this is super pressing, but we might consider adding a line to themerge_sce_list()
function to convert todgCMatrix
before returning.The text was updated successfully, but these errors were encountered: