Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index error after deleting target #34

Closed
ohaaga opened this issue Jul 24, 2024 · 1 comment · Fixed by #35
Closed

index error after deleting target #34

ohaaga opened this issue Jul 24, 2024 · 1 comment · Fixed by #35
Assignees

Comments

@ohaaga
Copy link
Contributor

ohaaga commented Jul 24, 2024

A rule deleting one vertex from the representable edge will not match using rewrite(), but will fire as the only rule of an ABM (and throws an index error).

https://gist.github.com/ohaaga/e7dd1df3e5ca557691e2bde700c06980

@kris-brown
Copy link
Collaborator

This comes from the fact that the incremental hom search functionality of AlgebraicRewriting comes with support for monic constraints + application conditions, but does not have any notion of the dangling condition! So the simplest way out is that AlgebraicABMs should just check for all DPO rules that, when it comes time to fire an event, check if the dangling condition is violated and move on if so. In principle this functionality could be added to the incremental hom set itself, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants