Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't append newlines inside a span #7

Closed
Alir3z4 opened this issue Apr 9, 2014 · 6 comments
Closed

Don't append newlines inside a span #7

Alir3z4 opened this issue Apr 9, 2014 · 6 comments

Comments

@Alir3z4
Copy link
Owner

Alir3z4 commented Apr 9, 2014

the pull request on mainstream have conflicts with code base, aaronsw/html2text#87.

@Alir3z4 Alir3z4 added the bug label Apr 9, 2014
@Alir3z4 Alir3z4 self-assigned this Apr 9, 2014
@Alir3z4
Copy link
Owner Author

Alir3z4 commented Apr 9, 2014

@mcepl the original commiter, @Moishe didn't provide any tests for it, he did actually but it had nothing to do with the change.

Branch fix-#7-dont-append-newlines-inside-span is there with the @Moishe changes, it only needs new unit-test to be good to get merged ;)

@mcepl
Copy link
Contributor

mcepl commented Apr 13, 2014

Branch fix-#7-dont-append-newlines-inside-span is there with the @Moishe changes, it only needs new unit-test to be good to get merged ;)

Ah, sorry, I missed that you’ve made it into branch, and I have just created the same as pull-request.

@harshil93
Copy link

I am wondering whether this has been fixed or not. I wasted my 2 days in finding out this.

This is the file. https://dl.dropboxusercontent.com/u/32632425/170594 .

I tried the nltk.clean_html() . It goes into an infinite loop.

@Alir3z4
Copy link
Owner Author

Alir3z4 commented Sep 7, 2014

@mcepl Your branch fixed it? I remember I fixed it in my branch as #7 (comment) but it needed a test case.

@mcepl
Copy link
Contributor

mcepl commented Sep 8, 2014

Actually, we've (or at least I ;)) concluded in https://github.com/html2text/html2text/pull/1 that it is actually WONTFIX, and html2text behaves correctly.

Or do I miss something?

@Alir3z4
Copy link
Owner Author

Alir3z4 commented Sep 20, 2014

This issue is closed and marked as wontfix and invalid.

@Alir3z4 Alir3z4 closed this as completed Sep 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants