Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another callsite attribute problem #1154

Closed
regehr opened this issue Jan 3, 2025 · 2 comments
Closed

another callsite attribute problem #1154

regehr opened this issue Jan 3, 2025 · 2 comments

Comments

@regehr
Copy link
Contributor

regehr commented Jan 3, 2025

I get a value mismatch from arm-tv on this input:

declare ptr @f0()

define ptr @f() {
  %1 = tail call noalias ptr @f0()
  ret ptr %1
}

it goes away if I remove the noalias. do you think I can just strip this attribute? again this is from the test suite, not from real code.

@nunoplopes
Copy link
Member

what's the source/target?
This is the output I get with latest Alive:

declare ptr @f0()

define ptr @f() {
#0:
  %#1 = tail call ptr @f0() noalias
  ret ptr %#1
}
=>
declare ptr @f0()

define ptr @f() noalias asm {
#0:
  %#1 = tail call ptr @f0() noalias
  ret ptr %#1
}
Transformation seems to be correct!

@regehr
Copy link
Contributor Author

regehr commented Jan 5, 2025

yeah, the issue is that I can't add these reliably to tgt since it's hard to match up the src and tgt.

but it seems like both you and I need to do some of this matching. currently the place where I'm stuck with the worst problems is indirect function calls. let's talk about this more sometime. meanwhile I'll close.

@regehr regehr closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants